Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link in DemuxFastqs.scala #938

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Fix link in DemuxFastqs.scala #938

merged 1 commit into from
Sep 25, 2023

Conversation

PeteHaitch
Copy link
Contributor

Fix markdown syntax

@PeteHaitch
Fix link in DemuxFastqs.scala
36cf4e4 
Fix markdown syntax
nh13
nh13 approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@nh13 nh13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank-you @PeteHaitch, you may consider looking at https://github.com/fulcrumgenomics/fqtk as a faster alternative that we've built!

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2af51ac) 95.60% compared to head (36cf4e4) 95.60%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #938   +/-   ##
=======================================
  Coverage   95.60%   95.60%           
=======================================
  Files         126      126           
  Lines        7308     7308           
  Branches      487      487           
=======================================
  Hits         6987     6987           
  Misses        321      321
Flag Coverage Δ
unittests 95.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../scala/com/fulcrumgenomics/fastq/DemuxFastqs.scala 96.69% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nh13 nh13 merged commit 4c1917b into fulcrumgenomics:main Sep 25, 2023
2 checks passed
@PeteHaitch
Copy link
Contributor Author

I did take a look at fqtk but conda was failing to resolve the dependencies on the machine I'm using.
I'll take another look when I'm not under such time constraints to get these particular samples demultiplexed.

@nh13
Copy link
Member

nh13 commented Sep 25, 2023

@PeteHaitch happy to help when you have time. DemuxFastqs was built a long time ago for a lot less data!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh13 nh13 nh13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PeteHaitch @codecov-commenter @nh13